Amanda Waite wrote: > > [resending to include sfwnv-discuss and setting reply-to to > webstack-discuss] > > Please review the webrev for the Lighttpd integration (CR6687382) at > http://cr.opensolaris.org/~tekgrrl/lighttpd14
5min race through http://cr.opensolaris.org/~tekgrrl/lighttpd14/lighttpd14.patch (patch code is quoted with "> " ...): > --- /dev/null Fri Apr 11 15:06:15 2008 > +++ new/usr/src/cmd/lighttpd14/Makefile.sfw Fri Apr 11 15:06:15 2008 > @@ -0,0 +1,90 @@ [snip] > +LIGHTTPD=lighttpd-1.4.18 > + > +LIGHTTPD_INSTALLDIR=/usr/lighttpd/1.4 > + > +RELEASENUM:sh=uname -r | sed -e 's/[^.]*//' Uhm... why should "RELEASENUM" depend on the version of the buildmachine's OS ? > +LIGHTTPD_CFLAGS="-xO3 -xbuiltin=%all -xinline=%auto -xprefetch=auto -xdepend > -I/usr/include/pcre -I/usr/mysql/5.0/include/mysql" Please add "-xc99=%all -D_XOPEN_SOURCE=600 -D__EXTENSIONS__=1" (to get the compiler behave more like gcc (C99/XPG6-like) and as a nice bonus system calls like |popen()|, |system()| etc. will use the POSIX shell instead of the Bourne shell (avoiding some complains in that area)) and "-xstrconst" (which puts string literals into the code section and therefore saves some memory) to these flags (if you hit any problems please email me via PM). > +# mimetype mapping > +mimetype.assign = ( [snip] > + ) AFAIK you forgot to map *.h, *.hxx, *.hpp, *.cpp and *.cxx to "text/plain" ... and entries for python (*.py), shell scripts (*.sh, *.ksh, *.bash), MNG (*.mng), TIFF (*.tiff) etc. may be nice > +#### compress module > +#compress.cache-dir = "/var/cache/lighttpd/compress/" > +#compress.filetype = ("text/plain", "text/html") Is compression support disabled during compile time or why is this left out ? > --- /dev/null Fri Apr 11 15:06:15 2008 > +++ new/usr/src/cmd/lighttpd14/install-sfw Fri Apr 11 15:06:15 2008 > @@ -0,0 +1,185 @@ > +#!/bin/sh -x Huh ? Why do you want "-x" (= execution trace) ? AFAIK you want "-e" (= error exit) in this case to stop the script when a command returns a non-zero exir code (=error) ... AFAIK that's all... ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) roland.mainz at nrubsig.org \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 7950090 (;O/ \/ \O;)
