Amanda, See comments below ...
Paul Amanda Waite wrote: > [resending to include sfwnv-discuss and setting reply-to to > webstack-discuss] > > Hi all, > > Please review the webrev for the Lighttpd integration (CR6687382) at > http://cr.opensolaris.org/~tekgrrl/lighttpd14 ====== Start of Comments ========================= 1. usr/src/Targetdirs + usr/src/cmd/Makefile You seem to have removed the 'nethack' stuff ! 2. usr/src/cmd/lighttpd14/Makefile.sfw Why is the compile bit under 'install-lighttpd:' and not under 'all:'? I don't think you would normally expect 'make all' to also do the install? 3. usr/src/cmd/lighttpd14/Solaris/fcgi-php.conf If this is specific to Solaris, should it have Sun Copyright stuff in it? 4. usr/src/cmd/lighttpd14/Solaris/http-lighttpd14.xml Sun Copyright message year/format wrong 5. usr/src/cmd/lighttpd14/Solaris/index.html If this is specific to Solaris, should it have Sun Copyright stuff in it? 6. usr/src/cmd/lighttpd14/Solaris/lighttpd.1m.sunman I don't think the format of the Sun copyright message is correct. 7. usr/src/cmd/lighttpd14/install-sfw + usr/src/cmd/lighttpd14/lighttpd.build.env + usr/src/pkgdefs/SUNWlighttpd14r/Makefile + usr/src/pkgdefs/SUNWlighttpd14r/pkginfo.tmpl + usr/src/pkgdefs/SUNWlighttpd14r/prototype_i386 + various others Copyright year is wrong 8. usr/src/pkgdefs/SUNWlighttpd14r/pkginfo.tmpl + usr/src/pkgdefs/SUNWlighttpd14u/pkginfo.tmpl I quiry whether the 'NAME=' and 'DESC=' lines should have the packages version on them ???? 9. file 'ident' strings Are the sccs 'ident' strings correct (check all files) as some of them are no the first version, eg. in usr/src/pkgdefs/SUNWlighttpd14r/prototype_com, etc. 10. usr/src/pkgdefs/SUNWlighttpd14r/prototype_i386 + usr/src/pkgdefs/SUNWlighttpd14r/prototype_sparc package name wrong SUNWvim ??? ====== End of Comments =========================== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
