Thanks Jyri, See answers inline: Jyri Virkki wrote: > Amanda Waite wrote: > >> Kindly review the updated WebRev for the Lighttpd integration at >> http://cr.opensolaris.org/~tekgrrl/lighttpd14-2/ >> > > *** usr/src/cmd/lighttpd14/Makefile.sfw > - It's building against "/usr/mysql" which is the obsolete MySQL4 which > AFAIK is going away any moment now. It should be using MySQL5 instead. >
Actually /usr/mysql/lib links to /usr/mysql/5.0/lib . Initially I specified the actual directory but then moved to the symlink so as to make it more future proof. I think that MySQL 4 is in /usr/sfw > - Why does it need "LD_LIBRARY_PATH=/opt/SUNWspro/lib", that seems odd? > This was done as a temporary measure to get round the mysql_config --libs problem. Basically it needs to find libcrun in the linker library path, at run time is uses the /usr/lib/libcrun.so but I was concerned about trying to coerce the linker to look into /usr/lib at build time. > - I assume "INSTALL=/usr/bin/ginstall" is because it fails with the > Solaris install? You should probably set a common define in > usr/src/Makefile.master for ginstall as is done for most other things > and then use that here. > Ok, don't know how to do that but I'll have a look, I'm not the only one to do it the way I've done though. > *** usr/src/cmd/lighttpd14/Solaris/index.html > - Please don't deliver a default index.html file. Unfortunately this isn't > set up yet (and unclear when it will be) but the intent is to move these > default index files to a distro-specific package so they can carry the > name/logo/etc of the distro. Delivering the index.html file now and > later having to make this package not be its owner is more hassle > which you could avoid. > I've read the rest of the discussion between you and Matt, I don't see a resolution yet though. Seems to me that I'll remove the index.html and it's associated image from SUNWlighttp14r, then if we decide to include it I'll add a new package just for the content, if we don't include it then we'll leave it as is. > *** usr/src/cmd/lighttpd14/Solaris/ssl.conf > - Does this create any problem given the out-of-the-box setup doesn't have > SSL set up yet? > How do you mean? it's not plugged in by default, the user has to generate a certificate and include ssl.conf in the main config file. > *** usr/src/cmd/lighttpd14/patches/lighttpd-nodelay.patch > - How are you tracking the adoption of the patch upstream? Is there a > bug filed? There isn't a standard way in sfw for this but I'd like to > see some documented tracking of these patches. Maybe include a comment in > Makefile.sfw near the line where the patch is applied or have a separate > text doc with pointers to the upstreams bug(s). > There's a bug logged, I'll add a comment to the Makefile.sfw > *** usr/src/pkgdefs/SUNWlighttpd14r/prototype_com > - The editable config files need some action (almost certainly 'renamenew') > IIRC my verification script catches this so please run it on your workspace. > That's new to me too, I've seen the renamenew files but I had no idea what they did. > - The contents of docroot are definitely also editable by the user or a > web server isn't much use ;-) Although given earlier comments these files > probably go away. > > *** usr/src/pkgdefs/SUNWlighttpd14u/depend > - Is it necessary to force all lighttpd users to install MySQL? Would it > be possible to factor out the dependency as was done in PHP? > I'll have to see what was done with PHP > - One of the config files earlier (fcgi-php.conf) references PHP but it's > not a dependency. Should it be (or factored out)? Or are those conf files > only examples that don't necessarily get used (in which case I'd at least > record the dependency in comments in the sample config)? > OK, I'll detail the dependency in the config file
