Roland Mainz wrote:
>> +LIGHTTPD=lighttpd-1.4.18
>> +
>> +LIGHTTPD_INSTALLDIR=/usr/lighttpd/1.4
>> +
>> +RELEASENUM:sh=uname -r | sed -e 's/[^.]*//'
>>
>
> Uhm... why should "RELEASENUM" depend on the version of the
> buildmachine's OS ?
>
Now removed, leftover from the Makefile.sfw I copied.
>
>> +LIGHTTPD_CFLAGS="-xO3 -xbuiltin=%all -xinline=%auto -xprefetch=auto
>> -xdepend -I/usr/include/pcre -I/usr/mysql/5.0/include/mysql"
>>
>
> Please add "-xc99=%all -D_XOPEN_SOURCE=600 -D__EXTENSIONS__=1" (to get
> the compiler behave more like gcc (C99/XPG6-like) and as a nice bonus
> system calls like |popen()|, |system()| etc. will use the POSIX shell
> instead of the Bourne shell (avoiding some complains in that area)) and
> "-xstrconst" (which puts string literals into the code section and
> therefore saves some memory) to these flags (if you hit any problems
> please email me via PM).
>
>
Ok, I'll add them and retest all the functionality.
>> +# mimetype mapping
>> +mimetype.assign = (
>>
> [snip]
>
>> + )
>>
>
> AFAIK you forgot to map *.h, *.hxx, *.hpp, *.cpp and *.cxx to
> "text/plain" ... and entries for python (*.py), shell scripts (*.sh,
> *.ksh, *.bash), MNG (*.mng), TIFF (*.tiff) etc. may be nice
>
I'll add the development file extensions, I'd chose not to display .py
files even though there currently is no specific filehandler in Lighttpd
for python files (done through FastCGI). The convention is not to return
the likes of .py, .php, .pl and .rb as text/plain so as to prevent
hackers from accessing your code. The same might be said for shell
scripts, so I'll leave them out as well. I've added an entry for tiff
>> +#### compress module
>> +#compress.cache-dir = "/var/cache/lighttpd/compress/"
>> +#compress.filetype = ("text/plain", "text/html")
>>
>
> Is compression support disabled during compile time or why is this left
> out ?
>
Compression support is included at build time, it's not enabled by
default at runtime as it's recommended to only enable functionality that
you know you need.
>
>> --- /dev/null Fri Apr 11 15:06:15 2008
>> +++ new/usr/src/cmd/lighttpd14/install-sfw Fri Apr 11 15:06:15 2008
>> @@ -0,0 +1,185 @@
>> +#!/bin/sh -x
>>
>
> Huh ? Why do you want "-x" (= execution trace) ? AFAIK you want "-e" (=
> error exit) in this case to stop the script when a command returns a
> non-zero exir code (=error) ...
>
That's a development bug, the lead integrator (i.e. me) seems to have
attention deficit disorder and forgets to undo things added for debugging.
Cheers
Amanda
