We'll work out how best to package the tests so that users can access 
them when they need them but as you point out they are not covered by 
the Arc Case and therefore will not be part of the integration. However 
as part of the integration it's required that we pass all applicable 
tests from the Lighttpd test suite and I'm currently working on this.

Thanks

Amanda

jean jayet wrote:
> as webstack integration of lighttpd into OpenSolaris is arriving
>
> validation scope intends to run the components existing OSS tests as non 
> regression to check the webstack integration does not break
>
> any lightttpd version is embedding its tests like for MySQL component 
> (downloading from the OSS web, the tests are coming along)
>
> the MySQL webstack integration into Nevada is delivering a dedicated 
> package SUNWmysql5test to be able to execute the tests coming with the 
> integrated version
>
> for other components like PHP and Apache, tests are not embedded within 
> the component version but available from the OSS separately : typically 
> when new versions of components are available in the OSS their tests are 
> not evolving but keep stable and are just intented to check non 
> regression vs any new version
>
> basically we get those Apache and PHP tests from the OSS, build them and 
> run them to point to the webstack integrated Apache or PHP
>
> reading the arc case for lightttpd, it seems tests will not be part of 
> the delivery and available as sources from http://opensolaris.org/
>
>
> is there a way to get the tests integrated for lightttpd ? i.e can we 
> keep the same way done for MySQL ?
>
>
> Jean
>
>
>
> Jyri Virkki wrote:
>   
>> Amanda Waite wrote:
>>     
>>> Kindly review the updated WebRev for the Lighttpd integration at 
>>> http://cr.opensolaris.org/~tekgrrl/lighttpd14-2/
>>>       
>> *** usr/src/cmd/lighttpd14/Makefile.sfw
>> - It's building against "/usr/mysql" which is the obsolete MySQL4 which
>>   AFAIK is going away any moment now. It should be using MySQL5 instead.
>> - Why does it need "LD_LIBRARY_PATH=/opt/SUNWspro/lib", that seems odd?
>> - I assume "INSTALL=/usr/bin/ginstall" is because it fails with the 
>>   Solaris install? You should probably set a common define in 
>>   usr/src/Makefile.master for ginstall as is done for most other things
>>   and then use that here.
>>
>> *** usr/src/cmd/lighttpd14/Solaris/index.html
>> - Please don't deliver a default index.html file. Unfortunately this isn't
>>   set up yet (and unclear when it will be) but the intent is to move these
>>   default index files to a distro-specific package so they can carry the
>>   name/logo/etc of the distro.  Delivering the index.html file now and
>>   later having to make this package not be its owner is more hassle
>>   which you could avoid.
>>
>> *** usr/src/cmd/lighttpd14/Solaris/ssl.conf
>> - Does this create any problem given the out-of-the-box setup doesn't have
>>   SSL set up yet?
>>
>> *** usr/src/cmd/lighttpd14/patches/lighttpd-nodelay.patch
>> - How are you tracking the adoption of the patch upstream? Is there a
>>   bug filed? There isn't a standard way in sfw for this but I'd like to
>>   see some documented tracking of these patches. Maybe include a comment in 
>>   Makefile.sfw near the line where the patch is applied or have a separate
>>   text doc with pointers to the upstreams bug(s).
>>
>> *** usr/src/pkgdefs/SUNWlighttpd14r/prototype_com
>> - The editable config files need some action (almost certainly 'renamenew')
>>   IIRC my verification script catches this so please run it on your 
>> workspace.
>> - The contents of docroot are definitely also editable by the user or a  
>>   web server isn't much use ;-)  Although given earlier comments these files
>>   probably go away.
>>
>> *** usr/src/pkgdefs/SUNWlighttpd14u/depend
>> - Is it necessary to force all lighttpd users to install MySQL? Would it
>>   be possible to factor out the dependency as was done in PHP?
>> - One of the config files earlier (fcgi-php.conf) references PHP but it's 
>>   not a dependency. Should it be (or factored out)? Or are those conf files
>>   only examples that don't necessarily get used (in which case I'd at least
>>   record the dependency in comments in the sample config)?
>>
>>
>>     
>
> _______________________________________________
>
>
> webstack-discuss mailing list
> webstack-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss
>   


Reply via email to