Update of patch #1032 (project wesnoth):
Status: None => In Progress
Assigned to: None => boucman
_______________________________________________________
Follow-up Comment #1:
thx for the patch, a couple of remarks
* you did not add yourself to the about.cfg
* you did not update the changelog
* your construction of the displayed message seems a bit complicated... if I
understand the problem correctly, there is only one victory message for all
local players ? Try to simplify that part a bit...
* you should reuse the carry_over_def variables instead of redefining new
ones
Though the patch is rather good, I'm not sure that's the way to go...
moreover, once we insert that patch we define a WML behaviour that we can't
change later
we need to call the exceptions properly. The exception is here to force an
exit of the level, but post level handling (i.e constructing the next level
thing) shouldn't be done here
my advice would be to pass a WML block with the exception, and parse that
block at exception catching time... that means changing all handling of end
level and then have an evolution to add "per player" results...
I don't know the code enough to have the details, could you look some more ?
don't hesitate to discuss here or on IRC with me
moreover, you should still link this patch to your SoC page... this is still
some code you have written and that we can review, and this patch is tricky,
getting it in time is feasible, but not trivial
Please go on, this would be a great feature to have.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1032>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
