Follow-up Comment #3, patch #1032 (project wesnoth):
I have reread the code, but not tested much yet...
* we can't apply the patch until you handle WML events in the [result]
part... can't you simply trigger the proper one ?
* you do a lot to try to optimize the handling of the various ending cases,
first regrouping continue, continue_no_save, and victory, then doing some
generic handling... there is probably a more readable way to handle this..
* your code has lots of @todo, most of these are for gameplay/scenario design
features that you didn't know how to handle, please come on IRC to discuss
these with our WML experts (shadow master, zookeeper, Rhuaven) they can help
you here more than I can
* no need to keep the old code in #if 0, it makes things more confusing and
we can use SVN to get it back if we need it
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1032>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
