Follow-up Comment #21, bug #17573 (project wesnoth):
Thonsew, against which version of Battle for Wesnoth are you developing your
patches? I developed mine against 1.8.5, in which the sdl_blit wrapper is not
present.
You are right that it is probably better to do this inside sdl_blit() in the
1.9.x trunk. I have attached a patch that does that. It is much less intrusive
than my 1.8.5 patch, but it has not been subject to the level of testing that
I did with my 1.8.5 patch.
I noticed that there is a blit_surface() function in sdl_utils.cpp that
appears to be a rewrite of SDL_BlitSurface(). It might be possible to avoid
the need for run-time checks entirely by using blit_surface(), although we
might want to talk to whoever wrote blit_surface() to verify that it is ready
for use before relying on it.
(file #12685)
_______________________________________________________
Additional Item Attachment:
File name: wesnoth-memcpy-workaround.2.patch Size:2 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?17573>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
