URL:
<http://gna.org/patch/?3862>
Summary: Fixed bug #20704: using 'apply_to=new_animation'
with 'id'
Project: Battle for Wesnoth
Submitted by: thunderstruck
Submitted on: Sun 21 Apr 2013 09:37:42 PM GMT
Priority: 5 - Normal
Status: None
Privacy: Public
Assigned to: None
Originator Email:
Open/Closed: Open
Discussion Lock: Any
_______________________________________________________
Details:
The bug was caused by accessing resources::controller after it was destroyed.
This was done for performance reasons to enable re-use of animations with a
help of animation_cache. But it seems that animation_cache was never
implemented.
The solution for the bug was simply to remove the code which caused the
problem. References to animation_cache have been removed as well since it is
not used anywhere.
Some arguments from IRC:
<lipkabb> It has an almost completely unnecessary dependance on the
controller.
<thunderstruck> lipkabb, that's what I think as well.
<lipkabb> Removing that dependency would make the code more robust, even if a
bit slower.
http://wiki.wesnoth.org/EffectWML is going to be updated after the patch is
accepted.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Sun 21 Apr 2013 09:37:42 PM GMT Name: new_animation_id.patch Size: 3kB
By: thunderstruck
<http://gna.org/patch/download.php?file_id=17793>
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?3862>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
