Hi, On Saturday 10 May 2008, Moritz Goebelbecker wrote: > Hi, > > Am Freitag, 09. Mai 2008 schrieb Bruno Wolff III: > > Is the cmake build process far enough developed that it is worth getting > > some wider testing? > > If so, can some instructions for doing so be posted? > > Most of build functionality should be there. Major things that are still > missing are building/installing manpages and manual and fribidi support. > > I have no idea regarding Windows/OSX support, afaik no one has tested it > yet. > > I just updated the INSTALL file with rudimentary instructions for cmake on > unix.
Just some comments: You don't have to test for if(COMMAND cmake_minimum_required), this exists in basically all cmake versions. You just test for cmake 2.4.x. I would strongly recommend to test for a specific release, since in the minor releases bugs were fixed and small new features were introduced. We (KDE) require 2.4.5, which works without problems for us. 2.4.3 was also ok, 2.4.4 was a bad release and very soon replaced by 2.4.5. Most distros today ship at least 2.4.6. If you can afford it, I would suggest to require cmake 2.6.0 and switch basically all "policies" to NEW, this should be better in most cases. cmake commands are case insensitive, but I would suggest you chose one style and stay with it for everything. I would suggest lower case, most developers like this better. I would also suggest to try to keep the top level CMakeLists.txt as small as possible, so it stays easy to understand. E.g. the python stuff could be moved into a separate module wesnoth/cmake/FindPythonSomething.cmake. Why do you build e.g. wesnoth-game with EXCLUDE_FROM_ALL ? You don't handle the RPATH yet, you probably want to do that. Which behaviour do you want for wesnoth ? It seems you don't install any libraries ? Is this correct ? (this makes things easier) All in all, it looks good :-) If you have questions, feel free to ask :-) Did you use some tool to generate the files ? Bye Alex _______________________________________________ Wesnoth-dev mailing list [email protected] https://mail.gna.org/listinfo/wesnoth-dev
