-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Alexander Neundorf schrieb: ~ > You don't have to test for if(COMMAND cmake_minimum_required), this exists in | basically all cmake versions.
The top was a patch supplied by patterner to allow compiling with cmake 2.6, too. It added the minimum_required stuff as well as the next block. | You just test for cmake 2.4.x. I would strongly recommend to test for a | specific release, since in the minor releases bugs were fixed and small new | features were introduced. We (KDE) require 2.4.5, which works without | problems for us. 2.4.3 was also ok, 2.4.4 was a bad release and very soon | replaced by 2.4.5. Most distros today ship at least 2.4.6. Okay, so we can easily set cmake 2.4.6 as minimum, right? Where there any syntax changes between 2.4.6 and 2.4.8 (since that is what I got here under gentoo)? | If you can afford it, I would suggest to require cmake 2.6.0 and switch | basically all "policies" to NEW, this should be better in most cases. I don't think we really can afford this since eg debian stable does only have cmake 2.4.7 IIRC. We basically would like to see all the major platforms (that is at least the linux distris) supported with cmake from the package manager... | It seems you don't install any libraries ? | Is this correct ? (this makes things easier) No, the libaries are only used to link, they are not meant to be installed. I don't know about the python tool stuff, those can probably be called libraries and eventually installing for them will have to be implemented, too... | All in all, it looks good :-) | If you have questions, feel free to ask :-) | | Did you use some tool to generate the files ? I tried to initially convert stuff with am2cmake, but it was a real failure. Afterwards I did it by hand to allow "basic building" and mog has done all the other stuff to really implement things. Cheers, Nils Kneuper aka Ivanovic -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEUEARECAAYFAkgnMmkACgkQfFda9thizwVx7wCcCKe9LC9n85ZWa0xlIeCkH84a ch0AmPygaEDZ+HO2fW8AtHD1M5NvgOc= =XNXf -----END PGP SIGNATURE----- _______________________________________________ Wesnoth-dev mailing list [email protected] https://mail.gna.org/listinfo/wesnoth-dev
