-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hrvoje Niksic wrote: > Micah Cowan <[EMAIL PROTECTED]> writes: > >> Could you be more specific? AFAICT, wget.h #includes the system headers >> it needs. Considering the config-post.h stuff went at the top of the >> sysdep.h, sysdep.h is already at the top of wget.h, > > OK, it should work then. The reasoning behind my worrying is the > following: in some (rare) cases, you need to make decisions and define > preprocessor *before* including anything. In other cases, you need to > base the decisions on the contents of header files, *after* having > included everything. Case #1 used to be handled by config-post.h (and > in some cases config.h), and case #2 by sysdep.h. You have now merged > them, which I don't necessarily see as a good thing.
Perhaps. I don't see any case #2s at the moment (except for where we explicitly #include the relevant header, but if we do, we'd obviously need another header. What I don't believe, though, is that it should be part of "config.h". That's a header file for a different purpose, AFA I'm concerned. It's not the idea of two system-dependency headers that bothers me, it's making config.h dependent on them, and then additionally not putting the header in the same location as config.h. >> working fine on my system (passes "make distcheck", which is _quite_ >> rigorous) > > That rigor has nothing to do with portability, though. It only > demonstrates that Wget correctly builds on *your* system. Agreed. And I expect that, between Automake and Gnulib, I've broken a number of things. Steven Schweda has started some testing on Tru64, and uncovered some interesting quirks; some of them look like flaws I've introduced, and others are bugginess in the Tru64 environment itself. It's proving very helpful. :) - -- Micah J. Cowan Programmer, musician, typesetting enthusiast, gamer... http://micah.cowan.name/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHGMwE7M8hyUobTrERCFqbAJ4oO5dmxfcWwfnSLA1RpiNKf2huPwCeO0cf 7OtVD70SUJzS6Qol7zcel+E= =gpxu -----END PGP SIGNATURE-----
