-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi,
The gnulib import has broken "make distcheck", in that the gnulib .c files in _build/lib depend on config.h (which it finds in _build/src), which itself depends on config-post.h (which is _not_ generated by configure, and so is not copied into the build directory). This happened to work previously, because the only .c files that depended on config.h, were src/, and of course for those -I$(srcdir) would have been let gcc find config-post.h. config-post.h strikes me as pretty hack-ish... it's stuff that would apparently normally go into sysdep.h (which is #included by wget.h), but has to be included before any system headers (it defines such such things as _GNU_SOURCE or _XOPEN_SOURCE, etc). We _could_ just have configure copy config-post.h into the build directory's src/. This is probably the easiest fix, but it's a kludge (as config-post.h itself is). Is there any reason we can't move the contents of config-post.h into sysdep.h, and have the .c files #include "wget.h" at the top, before any system headers? It seems natural to me to have project source files always include a "configuration" header prior to any system headers... we already do this with config.h. If we do move wget.h to the top, we may as well put the #include <config.h> (shouldn't that be "config.h"?) line in wget.h as well, instead of having each .c file #include it... that way, there is only one header file that is globally common. Is there anything in wget.h that should go after system headers? Nothing obvious to me... - -- Micah J. Cowan Programmer, musician, typesetting enthusiast, gamer... http://micah.cowan.name/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHF/v27M8hyUobTrERCFTlAJ0Q0sqTM16hfcim/hb2KmWk1DNeogCdH7h5 h9HUapTc6V0RX2AXXBD5pDc= =P3SZ -----END PGP SIGNATURE-----
