+1 to reverse this.

the point of having that sig in both interfaces is that the setting is
applicable in both places. it is both debug related and ajax related - this
functionality is the reason why jon and i went with a single object backing
multiple interfaces.

it also makes it easier for newbies to explore the settings. when i want to
see all ajax related settings i do getAjaxSettings(). and the ide lists them
all, when i want to see all the debug settings i do the same with
getDebugSettings(). it is not just a mere convinience.

yes IAjaxSettings only has a single setting in it, and so does
IFrameworkSettings but who is to say in a month we wont add one more to
either one? i think its ok to start settings interfaces even though they
start out with only a single method and that method is not exclusively
applicable to any existing settings interfaces.

yes this might ben an inconvinience for the jmx project- but that is
unrelated. either solve it there or leave it as is.

-Igor

On 10/16/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:

Yesterday I removed some double app settings, like
isAjaxDebugModeEnabled() that was defined both in IAjaxSettings
(removed) and in IDebugSettings. I did this because I was creating
that JMX code, and thought someone made copy 'n paste bug/ forgot to
remove a method after refactoring. Turns out, it was on purpose.

This is a vote to find out whether people want this change reversed.

I'm -1 because I think it's just crazy to have multiple interfaces
with the same method sigs just for convenience. Imo it's bloat without
real purpose, and it's even confusing. Imagine sitting behind that JMX
interface and wondering which isAjaxDebugModeEnabled you should set.

Also, I removed IAjaxSettings as isAjaxDebugModeEnabled() was the only
method in it. I don't think we need to go back to just one settings
interface, but we don't have to end up with too many of them either.
For instance, having framework settings as a different interface is ok
now that we have it, but wouldn't be my choice if we had to do it over
again.

Votes please?

Eelco

Reply via email to