Rob Lanphier wrote: > On Sun, Nov 14, 2010 at 11:58 AM, Jack Phoenix > <[email protected]> wrote: >> I want to have my SocialProfile-related commits (as well as other extension >> commits) reviewed, but the deferred status doesn't mean "review me later", >> it means "nobody cares about this revision", or at least currently it means >> that. Nowadays when a revision is marked as deferred, it's highly unlikely >> that anyone ever bothers reviewing it. Ideally there should be a way to tag >> commits, such as commits to extensions not used by WMF, as non-mission >> critical yet in need of review. > > Hi Jack, > > Yup, I agree this is a problem. We've got a manual way to tag > commits, but it seems to me what we really need is a way of > automatically tagging commits based on path. That would allow us to > automatically tag trunk commits in phase3 and WMF-deployed extensions > as "wmf-deployment" or something along those lines. We'd then > probably also need to beef up the tag functionality so that it's > possible/easier (?) to search for all "new"+"wmf-deployment" items, as > well as fix an apparent bug with the "total number of results" when a > tag is selected. We could then change our practice so that instead of > marking things as deferred, the people who are focused on > wmf-deployment reviews could filter based on that tag. > > Before finding someone willing to do this or getting too deep into the > implementation details, I think it's worth getting the opinion of > those doing the most code reviews whether this would be welcome > functionality, and whether it would be an acceptable change in > workflow once the functionality is in place. Code reviewers? > > Rob
You are changing the tools but not the problem. Jack wants his extension reviewed. Nobody seem to care about it. Naming it 'without wmf-deployment flag' instead of 'marked as deferred' won't help. Perhaps having a description attached to the paths, and shown when the revision is viewed would be benefitial: "Extension Foo does X, alpha stage, expect lots of changes" (don't care too much to review, _should_ get a full review later), "Extension Bar allows all wikipedias to magically write articles" (must be reviewed), "Extension Baz is intended for Wikinews filling bug 1234" (should be looked at, but it's not too important) _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
