On Sun, Nov 14, 2010 at 4:35 PM, Tim Starling <[email protected]> wrote: > On 15/11/10 06:58, Jack Phoenix wrote: >> The deployment queue is already long enough and people who are reviewing >> code for Wikimedia deployment are having a hard time catching up; I don't >> want to make their work any more difficult than it already is, I just want >> to have my extensions reviewed to make sure that no glaring errors or >> security vulnerabilities slip in. > > I think that if you want a favour, you should politely ask the > specific person you want it from, rather than complaining about a > general lack of generosity.
I didn't read Jack's comment as a complaint about anyone's generosity (though admittedly, it's a little tough to parse that sentence). I read it as acknowledging the fact(?) that the review queue is too long to get through without marking some extensions/etc as "deferred". After discussing this with Jack on IRC[1], I encouraged him to send this email. This seems like a real problem. If Jack wants someone to review his code, should he simply move it back from "deferred" to "new"? What criteria are used to mark something as "deferred" in the first place? I'm assuming it's currently standard practice to mark extensions that aren't slated for deployment by WMF as "deferred"; do I have that right? Rob [1] http://toolserver.org/~mwbot/logs/%23mediawiki/20101112.txt ...starting at "[17:47:55] <ashley> speaking of things in SVN vs. things used by WMF..." _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
