User "Happy-melon" posted a comment on MediaWiki.r84534. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84534#c23921 Commit summary:
(hopefully) last bit of heavy lifting in Block.php: now that we've internalised most of the variables, untangle their twisted connections to the database layer and remove various now-unused protected methods and variables. Comment: http://pastebin.com/ikAauVQs is the patch I would suggest to resolve the problem, but I do not have a working CentralAuth system set up to test it on. Would anyone mind having a look? It's basically the same method as the orgiginal patch, but a) suggests a long-term plan to resolve the issue more cleanly, and b) makes an attempt to find the steward's local id and uses it if possible. I think these blocks would be displayed wrongly in Special:BlockList (both with and without this patch), although since their entire purpose is to ''not'' be displayed, that's not a major concern. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
