User "Brion VIBBER" posted a comment on MediaWiki.r84534.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84534#c24335
Commit summary:
(hopefully) last bit of heavy lifting in Block.php: now that we've internalised
most of the variables, untangle their twisted connections to the database layer
and remove various now-unused protected methods and variables.
Comment:
<pre>
+ $byUser = new self( $by );
+ if( $byUser instanceof CentralAuthUser ){
</pre>
Since this code is in CentralAuthUser, won't it by definition be a
CentralAuthUser?
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
