User "Aaron Schulz" posted a comment on MediaWiki.r84534. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84534#c24334 Commit summary:
(hopefully) last bit of heavy lifting in Block.php: now that we've internalised most of the variables, untangle their twisted connections to the database layer and remove various now-unused protected methods and variables. Comment: Looks like the "$byName = $byUser->getName();" line should just go in one place instead of two. Otherwise the patch looks sane (aside from not dealing with BlockList display). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
