"Wikinaut" posted a comment on MediaWiki.r111263.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111263#c30850

Commit summary for MediaWiki.r111263:

initial import of new extension EtherpadLite

Wikinaut's comment:

@Bawolff: in r111313 I fixed (I think) all of the issues.

Let me explain here:
1. I changed the attribute names from pad-id => id and pad-url => src. This 
allows to treat (id, src, height, width) as standard attributes and to use 

$sanitizedAttributes = Sanitizer::validateAttributes( $args, array ( "width", 
"height", "id", "src" ) );

for this, and then to use $santizedAttributes['src'] for example.

The boolean parameters are manually checked. 

Please have a look to r111313 . Documentation 
https://www.mediawiki.org/wiki/Extension:EtherpadLite has been updated as well.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to