"Bawolff" posted a comment on MediaWiki.r111263. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111263#c30869
Commit summary for MediaWiki.r111263: initial import of new extension EtherpadLite Bawolff's comment: The issue I'm concerned about is this results in invalid html, since the same id cannot appear twice in one page. So if someone embeds two pads in the same page, there will be two iframes in the page, both with the id ''eplite-iframe-'', which will cause the html not to be valid. Since you're not using the id attribute for anything, it might make sense just not to put an id on the iframes. (From a pragmatic perspective, the invalid html won't hurt anything, it will just cause the validator to whine) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
