"Wikinaut" posted a comment on MediaWiki.r111263.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111263#c30872

Commit summary for MediaWiki.r111263:

initial import of new extension EtherpadLite

Wikinaut's comment:

"...since the same id cannot appear twice in one page."

Of course, you are 100% right, I overlooked this (never ignored it, but today.) 
Will use, as suggested by you, "class=" instead. 

"Since you're not using the id attribute for anything":

This is just for the case, that another extension will have the need to 
manipulate that specific frame. I took it over from the example "Etherpad lite 
and jQuery" 
https://github.com/johnyma22/etherpad-lite-jquery-plugin/blob/master/js/etherpad.js
 where the content also can be read. I did not implement this part in the 
current version.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to