"Bawolff" posted a comment on MediaWiki.r111263. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111263#c30871
Commit summary for MediaWiki.r111263: initial import of new extension EtherpadLite Bawolff's comment: I mean the id for the iframe. At the moment, the iframe id is set to the same thing as the pad id (earlier i didn't realize that that value was also used for what pad to get, which is why my comment is a little confusing. I thought it was solely for setting the id attribtue on the iframe). id's on html elements have to be unique (in a page), so it might be best just not to put an id attribute on the iframe. (I mentioned the class attribute, because typically classes are used for the same purpose as the id attribute, but don't have the uniqueness requirement). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
