On Fri, Dec 28, 2012 at 12:57 PM, Juliusz Gonera <[email protected]> wrote: > On 12/27/2012 10:31 AM, Matthew Flaschen wrote: > >>> * What is the difference between +1 and +2, especially in Verified? >> >> I think just how certain you are. > > > I still don't get it. I either think the code is good and should be merged > or it's not good enough and shouldn't be merged. I don't see any situations > in between, but maybe it's just me ;)
In Verified, it's whether Jenkins ran only the linting tests or also the unit tests. In Code Review for people who have +2 access, marking +1 typically means "I think it's good, but I'd like others to take a look", while marking it +2 typically means "Hey Jenkins, run the final unit tests and then merge this!". > This still seems redundant. If Jenkins runs tests only when I give +2, but I > am supposed to give +2 only if I already run the tests myself manually, then > what's the point? Once things are set up to do it safely, Jenkins will start running unit tests again when the new patch set is initially uploaded. _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
