On 12/27/2012 10:31 AM, Matthew Flaschen wrote:
* What is the difference between +1 and +2, especially in Verified?
I think just how certain you are.
I still don't get it. I either think the code is good and should be
merged or it's not good enough and shouldn't be merged. I don't see any
situations in between, but maybe it's just me ;)
+2 means it's ready to merge. In core, this will cause unit tests to
run, and if they pass, it will automatically merge.
I don't know of any reason (in any code) to vote CR +2 if you don't
think it's ready to merge.
This still seems redundant. If Jenkins runs tests only when I give +2,
but I am supposed to give +2 only if I already run the tests myself
manually, then what's the point?
And I guess we don't have that auto-merging behavior in mobile.
Juliusz
_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
