On 12/28/2012 12:57 PM, Juliusz Gonera wrote: > On 12/27/2012 10:31 AM, Matthew Flaschen wrote: > >>> * What is the difference between +1 and +2, especially in Verified? >> I think just how certain you are. > > I still don't get it. I either think the code is good and should be > merged or it's not good enough and shouldn't be merged. I don't see any > situations in between, but maybe it's just me ;)
Okay, some people (depending on permissions) can't vote +2, in which case it's easy. But if you can vote either, it is somewhat of a weird gut thing. +2 means you're sure it's ready to merge. >> +2 means it's ready to merge. In core, this will cause unit tests to >> run, and if they pass, it will automatically merge. >> >> I don't know of any reason (in any code) to vote CR +2 if you don't >> think it's ready to merge. > > This still seems redundant. If Jenkins runs tests only when I give +2, > but I am supposed to give +2 only if I already run the tests myself > manually, then what's the point? No, you (people) do not have to test to do CR +2 (though if you do, you get bonus points). V (Verified) means you actually tested (manually or automatically, depending on project). Also, Jenkins currently only does this "CR +2 and passing tests" == "automatic merge" in core. In other projects, people have to merge manually, but CR +2 should still be a pre-requisite. Matt Flaschen _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
