Can git notes be changed after merge? Do they show in Gerrit diffs, so we don't accidentally lose them if someone else pushed an amend without the tags?
Can they be removed after merge? Can one query for commits having a certain tag within a repo/branch/author? (eg. "fixme" commits by me in mw core) If not on displayed in Gerrit, then from git-cli via a web tool (how does that grep perform, is it fast enough?) Ofcourse, changing would still go from cli (not w/ the web tool). -- Krinkle On 14 mrt. 2013, at 00:07, Christian Aistleitner <christ...@quelltextlich.at> wrote: > Hi, > > On Tue, Mar 12, 2013 at 08:28:25PM -0700, Rob Lanphier wrote: >> The Bugzilla-based solution has some of the advantages of the >> MediaWiki-based solution. We may be able to implement it more quickly >> than something native to Gerrit because we're already working on >> Bugzilla integration, and we get features like queries for free, as >> well as the minor convenience of not having to have a new database >> table or two to manage. > > The problem at this point is that the gerrit-plugin interface is > rather new, and that shows at various ends: > * It's not possible to add GUI elements from a plugin. > * Plugins cannot add their own database tables through gerrit. > [...] > > So whatever we could possibly get into upstream gerrit, we should > really try to get into upstream and not put into the plugin. > > But thinking about whether gerrit or bugzilla would be the correct > place to store those tags ... > It seems to me that the tags are not really tied to issues or changes, > but rather to commits... > Wouldn't "git notes" be a good match [1]? > > They're basically annotations attached to commits. You can add/remove > them to any commit without changing the actual commit. And support > comes directly with git, as for example in > > git log --show-notes > > Queries are just a grep away, and setting them can be done through git > as well, until we integrate that into gerrit. > > Best regards, > Christian > > P.S.: We already use "git notes". They contain links to code > review. But we could add lines like > Tag: fixme > and have them automatically show when reading the logs. > > > -- > ---- quelltextlich e.U. ---- \\ ---- Christian Aistleitner ---- > Companies' registry: 360296y in Linz > Christian Aistleitner > Gruendbergstrasze 65a Email: christ...@quelltextlich.at > 4040 Linz, Austria Phone: +43 732 / 26 95 63 > Fax: +43 732 / 26 95 63 > Homepage: http://quelltextlich.at/ > --------------------------------------------------------------- > _______________________________________________ > Wikitech-l mailing list > Wikitech-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/wikitech-l _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
