On 11 April 2014 09:29, Aaron Schulz <[email protected]> wrote:

> What if someone -1's due to something in the summary? It's odd that fixing
> it
> with a new commit would still show -1 on the reviewer's dashboard.


​Sure, but ​those are relatively rare for simple changes (normally you just
fix it yourself, with a CR explaining why); if it's the edge case of the -1
being "I don't understand what the reasoning is for this change in the
commit summary", then I think it's appropriate for the -1 to remain until
the original reviewer can comment.

J.​
-- 
James D. Forrester
Product Manager, VisualEditor
Wikimedia Foundation, Inc.

[email protected] | @jdforrester
_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Reply via email to