On 14 April 2014 12:06, Antoine Musso <[email protected]> wrote: > Le 11/04/2014 15:57, Christian Aistleitner a écrit : > > TL;DR: Gerrit would allow to keep Code-Review votes across > > * rebases and > > * commit message modifications > > of patch sets. > > > > Thereby dropping need to re-review “trivial” changes on patch sets. > > > > Shall we turn that feature on? > <snip> > > Thank you Christian to raise this publicly :-] > > Gerrit knows about two different trivial changes: > > - trivial rebase: the new patchset is the same diff but the parent has > changed. This is often fine but the new patch my not be working > anymore. Though if that happens tests will catch it. > > - no code change: only the commit summary has changed. Ie the proposed > code is exactly the same and should have the same behavior. > > Details: > > https://gerrit.wikimedia.org/r/Documentation/config-labels.html#label_copyAllScoresOnTrivialRebase > > I am fine reapplying scores for both types. >
It looks to me like we have rough consensus for doing this. Make it so? J. -- James D. Forrester Product Manager, VisualEditor Wikimedia Foundation, Inc. [email protected] | @jdforrester _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
