+1 I never liked this, over and over I point out a fatal issue with a commit sometimes fundamental to the idea itself and impossible to fix, so I -1 it, then when a new patchset comes out, completely ignores the concerns I've pointed out, my -1 with the idea suddenly disappears as if the changeset was supposed to fix it. When I was drafting Gareth ideas I explicitly avoided that issue in my "plins". First allowing users to apply two types of -1/+1 one that went away each commit and another intended for fundamental objections to the idea which never went away. And second by making it so that the -1/+1s that go away don't actually go away, they would still show up in the list, semi-transparent and greyed out, to indicate that someone -1ed a prior version but they haven't reviewed the current commit and it may not apply any longer.
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://danielfriesen.name/] On 2014-04-11, 6:57 AM, Christian Aistleitner wrote: > Hi, > > TL;DR: Gerrit would allow to keep Code-Review votes across > * rebases and > * commit message modifications > of patch sets. > > Thereby dropping need to re-review “trivial” changes on patch sets. > > Shall we turn that feature on? _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
