+1 for <Content/> I can see that being useful in other places too.

Neil

From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: 08 May 2014 15:38
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] WIXFEAT:4149 - Add UninstallSuccess page to WixStdBA

Could this be as simple as supporting a Visible/Enabled attribute on 
Text/Hypertext elements? We could then evaluate the attribute when changing 
pages, and the attribute could contain references to burn variables.

Another option (that I really like) would be to introduce a <Content /> element 
that could be a child of the Text/Button controls and could support a condition 
on it.  Ex:
    <Page Name="Success">
        <Text X="11" Y="80" Width="-11" Height="30" FontId="2" 
DisablePrefix="yes">
                 <Content Condition="WixBundleAction = 
2">#(loc.LayoutSuccessHeader)</Content>
                 <Content Condition="WixBundleAction = 
3">#(loc.UninstallSuccessHeader)</Content>
                 <Content Condition="WixBundleAction = 
5">#(loc.ModifySuccessHeader)</Content>
                 <Content Condition="WixBundleAction = 
6">#(loc.RepairSuccessHeader)</Content>
                 <Content>#(loc.SuccessHeader)</Content>
         </Text>

...

Jacob
From: Neil Sleightholm [mailto:n...@x2systems.com]
Sent: Thursday, May 08, 2014 1:40 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] WIXFEAT:4149 - Add UninstallSuccess page to WixStdBA

>> so saying "Setup Successful" after uninstall is confusing to most people.

+1 - I get lots of complaints about this, IMO is makes no sense.

Neil

    Bob: I'm also convinced that uninstall isn't *that* special.

Well, I guess I can try to convince you :) It's special because if you want to 
say anything more than "Success" and "Restart Required", it's impossible to 
have it make sense after an install and an uninstall.  I would say that only 
setup developers think of "Setup" including install, modify, repair, and 
uninstall so saying "Setup Successful" after uninstall is confusing to most 
people.  The default restart message for the Success page is "You must restart 
your computer before you can use the software.", which is just wrong for 
uninstall.

    Rob: Isn't there only one success and error page in an MSI?

Didn't I see a discussion with you and Neil about being able to improve on 90's 
UI? :)  If we don't add pages, then ThmViewer is going to have to be updated to 
let you modify the environment so that you can do something about all of the 
overlapping controls.

    Rob: I think something like what Heath said below with conditions to 
hide/show controls plus the ability to have text resolve variables...

It's starting to sound like this is definitely the way to go.

    Rob: It may be that we finally need to move the condition and variable 
system out of Burn and into dutil (so thmutil could access it easily), but 
that's something I've proposed before. Or maybe thmutil can do it all with 
callbacks (i.e. please evaluate this string as true or false for me).

I don't think moving it into dutil is a bad idea, but I don't see what that 
gets you here.  Since the engine is the one that has the values for all the 
variables, thmutil will have to depend on callbacks (or a COM interface, or 
...).

I don't have time to work on this big of a feature for 3.9, I'm more interested 
in getting 3249 and 4161 in there.
------------------------------------------------------------------------------
Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
&#149; 3 signs your SCM is hindering your productivity
&#149; Requirements for releasing software faster
&#149; Expert tips and advice for migrating your SCM now
http://p.sf.net/sfu/perforce
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs

Reply via email to