On 18-Nov-14 10:19, PavelAnfimov wrote: > Why not take advantage of our implementation until you finish yours? Our > implementation adds the requested features already now, affecting the > minimum numbers of lines of source code, as in bootstrapper theme files, and > in source code of WixStdBa. I haven't yet reviewed your change in detail but the biggest reason I objected to a similar approach discussed previously is that it complicates upgrading from WiX v3.x to v4.x when using a customized theme. I'll be reviewing your pull request sometime this week.
-- sig://boB http://joyofsetup.com/ ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk _______________________________________________ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
