I sent in my pull request for adding the EnableCondition and
VisibleCondition attributes, I think that pretty much covers the core
functionality (https://github.com/wixtoolset/wix4/pull/64).  It also fixes
http://wixtoolset.org/issues/4496/ in v4.x (I think 4568 is actually a
duplicate of this).

I see that someone sent another pull request for this feature -
https://github.com/wixtoolset/wix4/pull/65.  I think we decided that
approach was in the wrong direction?

I'd like to implement the Content idea, but Content in WPF can contain
anything so I'd kind of like to change the name.  Maybe ConditionalText?

<Text>
    #(loc.DefaultText)
    <ConditionalText Condition="WixBundleAction =
6">#(loc.RepairText)</ConditionalText>
</Text>

By the way, I'm not interested in figuring out to backport this stuff from
v4.0.

Sean

On Thu, Nov 6, 2014 at 5:09 AM, Rob Mensching <r...@firegiant.com> wrote:

>  Jacob, what about putting the condition on other elements? That way one
> could disable controls (and there is already a HideWhenDisabled bit)?
> Technically, if conditions were allowed on the existing elements then we
> wouldn’t need “Content” elements… but one would need to duplicate all the
> attributes without the Content concept.  So I’m mixed there.
>
>
>
> Tobias, the change looks like it can be done additive so it could be back
> ported to v3.x if Jacob chooses to do the work (looks like this is actually
> of the wix3 branch now).
>
>
>
> _______________________________________________________________
>
> FireGiant  |  Dedicated support for the WiX toolset  |
> http://www.firegiant.com/
>
>
>
> *From:* Tobias Erichsen [mailto:i...@tobias-erichsen.de]
> *Sent:* Wednesday, November 5, 2014 1:13 AM
> *To:* WiX toolset developer mailing list
> *Subject:* Re: [WiX-devs] WIXFEAT:4149 - Add UninstallSuccess page to
> WixStdBA
>
>
>
> Hi everyone,
>
>
>
> I was wondering if that would be something that we could put into 3.10?
>
>
>
> I also get quite a few complaints that the success-page of uninstall is
>
> a bit puzzling...
>
>
>
> Best regards,
>
> Tobias
>
>
>  ------------------------------
>
> *Von:* Hoover, Jacob [jacob.hoo...@greenheck.com]
> *Gesendet:* Donnerstag, 8. Mai 2014 22:18
> *Bis:* WiX toolset developer mailing list
> *Betreff:* Re: [WiX-devs] WIXFEAT:4149 - Add UninstallSuccess page to
> WixStdBA
>
> If anyone is brave, I have a proof of concept functioning for controls
> within a page with conditional  Content. (You’ll have to customize your
> theme to test it, and it only works on the controls within the page - not
> the application controls.)
>
>
>
> https://github.com/jchoover/wix3/tree/WIXFEAT4149
>
>
>
>
>
>
>
> *From:* Neil Sleightholm [mailto:n...@x2systems.com <n...@x2systems.com>]
> *Sent:* Thursday, May 08, 2014 11:03 AM
> *To:* WiX toolset developer mailing list
> *Subject:* Re: [WiX-devs] WIXFEAT:4149 - Add UninstallSuccess page to
> WixStdBA
>
>
>
> +1 for <Content/> I can see that being useful in other places too.
>
>
>
> Neil
>
>
>
> *From:* Hoover, Jacob [mailto:jacob.hoo...@greenheck.com
> <jacob.hoo...@greenheck.com>]
> *Sent:* 08 May 2014 15:38
> *To:* WiX toolset developer mailing list
> *Subject:* Re: [WiX-devs] WIXFEAT:4149 - Add UninstallSuccess page to
> WixStdBA
>
>
>
> Could this be as simple as supporting a Visible/Enabled attribute on
> Text/Hypertext elements? We could then evaluate the attribute when changing
> pages, and the attribute could contain references to burn variables.
>
>
>
> Another option (that I really like) would be to introduce a <Content />
> element that could be a child of the Text/Button controls and could support
> a condition on it.  Ex:
>
>     <Page Name="Success">
>
>         <Text X="11" Y="80" Width="-11" Height="30" FontId="2"
> DisablePrefix="yes">
>
>                  <Content Condition=”WixBundleAction = 2”>
> #(loc.LayoutSuccessHeader)</Content>
>
>                  <Content Condition=”WixBundleAction = 3”>
> #(loc.UninstallSuccessHeader)</Content>
>
>                  <Content Condition=”WixBundleAction = 5”>
> #(loc.ModifySuccessHeader)</Content>
>
>                  <Content Condition=”WixBundleAction = 6”>
> #(loc.RepairSuccessHeader)</Content>
>
>                  <Content>#(loc.SuccessHeader)</Content>
>
>          </Text>
>
>
>
> …
>
>
>
> Jacob
>
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs

Reply via email to