On Thu, Jan 07, 2010 at 11:48:41AM +0100, Carlos R. Mafra wrote: > On Mi 6.Jan'10 at 12:50:36 -0500, Brad Jorsch wrote: > > We already have ClipRaiseKey, ClipLowerKey, and ClipRaiseLowerKey. Why > > not DockRaiseKey, DockLowerKey, and DockRaiseLowerKey too? I sometimes > > put a window over part of the dock, and I find myself missing a > > raise-dock shortcut. > > Why not restrict to having just DockRaiseLowerKey?
We already have ClipRaiseKey and ClipLowerKey in addition to ClipRaiseLowerKey, so I added all three for Dock for parallelism. > It seems to me that having a "raise only" (or "lower only") shortcut > is superfluous. If the dock is already raised than there is no point > in raising it, and lowering will be achieved by the wDockRaiseLower() > function already. It depends on your workflow. In pseudocode: /* Having separate raise and lower is superfluous here */ look_at_clip(); if(clip_is_hidden()) activate_shortcut(); /* Having separate raise and lower is necessary here */ activate_shortcut(); look_at_clip(); The latter may well be faster for some people, especially if activate_shortcut() has become automatic. > > + case WKBD_DOCKLOWER: > > + if (!wPreferences.flags.nodock) > > + wDockLower(scr->dock); > > + break; > > I didn't test it yet, but doesn't it mean that it will lower > the dock on all workspaces from 'scr'? Yes. > See what is done for the clip, only the current workspace is > affected: The difference is that there is a separate clip per workspace, while the one dock is shared by all. That's why the WDock *clip is in the WWorkspace struct while the WDock *dock is in WScreen. Unless you changed that in your 'next' branch, I haven't checked that out yet. Looking at the code, it seems that there is only one window stack for the whole screen, so raising *any* window anywhere raises it on all workspaces. But since most windows are not omnipresent, you don't often notice it in the UI. One way to notice this is to note the behavior of a RaiseLower shortcut: even if the window is already the top window visible, the shortcut will still "raise" it if some window on another workspace is higher. On Thu, Jan 07, 2010 at 12:26:33PM +0100, Carlos R. Mafra wrote: > Brad, is the modified patch OK for you? As I kept you as the > author I want to be sure (I can remove it from 'next' if > necessary). Works for me. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
