On Fr 8.Jan'10 at 11:48:34 -0500, Brad Jorsch wrote: > On Thu, Jan 07, 2010 at 11:48:41AM +0100, Carlos R. Mafra wrote: > > > > Why not restrict to having just DockRaiseLowerKey? > > We already have ClipRaiseKey and ClipLowerKey in addition to > ClipRaiseLowerKey, so I added all three for Dock for parallelism.
Right, but after seeing your patch what I also did was to remove the ClipLowerKey and ClipRaiseKey. > > > + case WKBD_DOCKLOWER: > > > + if (!wPreferences.flags.nodock) > > > + wDockLower(scr->dock); > > > + break; > > > > I didn't test it yet, but doesn't it mean that it will lower > > the dock on all workspaces from 'scr'? > > Yes. > > > See what is done for the clip, only the current workspace is > > affected: > > The difference is that there is a separate clip per workspace, while the > one dock is shared by all. That's why the WDock *clip is in the > WWorkspace struct while the WDock *dock is in WScreen. Unless you > changed that in your 'next' branch, I haven't checked that out yet. Yes, and I haven't changed that. > Looking at the code, it seems that there is only one window stack for > the whole screen, so raising *any* window anywhere raises it on all > workspaces. But since most windows are not omnipresent, you don't often > notice it in the UI. What you say is true, but I was talking about the dock itself, not about omnipresent windows. Suppose you have a fully maximized xterm on workspace 1 (covering the dock) and a fully maximized firefox on workspace 3. Now you raise the dock on workspace 3 and it will also be raised over the xterm on workspace 1. You agreed with it in your "Yes" above, so all is fine :-) I liked your patch and I am already using it. Right now I am writing this email on a fully maximized xjed and I can quickly see the dock with the shortcut whenever I want. Cool! -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
