On 8 Jan 2010, at 20:10, Carlos R. Mafra wrote:

On Fr  8.Jan'10 at 11:48:34 -0500, Brad Jorsch wrote:
On Thu, Jan 07, 2010 at 11:48:41AM +0100, Carlos R. Mafra wrote:

Why not restrict to having just DockRaiseLowerKey?

We already have ClipRaiseKey and ClipLowerKey in addition to
ClipRaiseLowerKey, so I added all three for Dock for parallelism.

Right, but after seeing your patch what I also did was to remove the
ClipLowerKey and ClipRaiseKey.

A single RaiseLower key doesn't work all the time. What will it do in this case?

Window
Dock
Window

If you press it will it lower or raise the dock? In that case it depends on it's last state and you may have to press it twice to get it where you want it.

It can be done with a single key though, but it should not act like a toggle. It needs to analyze the window stack and always raise if there is at least a window above and lower only if there is none, since this is what the user expects. I'm not sure if this can be done with the current code as the dock may not be in the window stack list (I can't remember the code).

P.S. it would be really nice if things would be well thought over before code is written.

--
Dan




--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.

Reply via email to