On Sa 9.Jan'10 at 17:39:37 +0200, Dan Pascu wrote: > On 8 Jan 2010, at 20:10, Carlos R. Mafra wrote: > > >On Fr 8.Jan'10 at 11:48:34 -0500, Brad Jorsch wrote: > >>On Thu, Jan 07, 2010 at 11:48:41AM +0100, Carlos R. Mafra wrote: > >>> > >>>Why not restrict to having just DockRaiseLowerKey? > >> > >>We already have ClipRaiseKey and ClipLowerKey in addition to > >>ClipRaiseLowerKey, so I added all three for Dock for parallelism. > > > >Right, but after seeing your patch what I also did was to remove the > >ClipLowerKey and ClipRaiseKey. > > A single RaiseLower key doesn't work all the time. What will it do > in this case? > > Window > Dock > Window > > If you press it will it lower or raise the dock? In that case it > depends on it's last state and you may have to press it twice to get > it where you want it.
If I understood your example above as denoting that the user is not currently seeing the dock because it is in the "middle" of two windows, then my answer would be that the shortcut using DockRaiseLowerKey will raise the dock so that the user will see it. That is what I understood from reading the code (I also did some brief experiments with two windows and the dock). Of course I may be wrong. But so far that is what is happening with me using this shortcut and it matched my (maybe naive) expectations. I haven't tested the clip because I never use it, but as the 'raise' and 'lower' actions use the same function as the dock, I expect that the answer is the same in this case. > P.S. it would be really nice if things would be well thought over > before code is written. We all do our best, given the circunstances. Being a wmaker user for 10 years I will be the first to scream if my wmaker breaks. And when it breaks it is just a matter of un-breaking it again. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
