Hi Frank, Just to let you know, the test in question passes in citeproc-ruby too. After some digging I found the commit that sets the default to 1 to refer to this being citeproc-js' default value specifically (likely inferred from the test at hand). If you remove the default value, I'll also remove it from citeproc-ruby.
Sylvester On Sun, 2016-09-04 at 14:51 +0900, Frank Bennett wrote: > This weekend, I'm overhauling some of the names code in citeproc-js, > to fix some long-standing bugs in attribute inheritance. One of the > test failures doesn't actually look like a failure, and I'd like to > confirm that I'm not misreading the spec. > > The test is this one: > > https://github.com/citation-style-language/test-suite/blob/master > /processor- > tests/humans/nameattr_EtAlUseFirstOnCitationInBibliography.txt > > In the fixture, a value for et-al-min is set on separate cs:name > nodes > inside cs:citation and cs:bibliography, and a value of 2 for > et-al-use-first is set on the cs:citation node. The test renders the > bibliography. > > The bibliography comes out with all three names given in the input. > The fixture RESULT has one name, truncated by et al. > > I don't see anything in the spec about defaulting to a value of 1 for > et-al-use-first, and it says that "[u]se of these two attributes > enables et-al abbreviation." Since the test provides a value for only > one of the attributes inside cs:bibliography, it sounds like listing > all three names there is the right thing to do (and the original > RESULT string was wrong). > > So ... should I amend the test there? > > Frank > > ------------------------------------------------------------------- > ----------- > _______________________________________________ > xbiblio-devel mailing list > xbiblio-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/xbiblio-devel
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------------
_______________________________________________ xbiblio-devel mailing list xbiblio-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbiblio-devel
