On Fri, Nov 26, 2010 at 1:32 PM, Stoli <[email protected]> wrote:
> - addon -skin.neon
> - version - 0.5
> - url - git://github.com/stoli/skin.neon.git
> - branch - master
> - revision - 84d804d
> - xbmc version - dharma
>
> My first attempt at this - be gentle. :-)
>
> Thanks.
> stoli
>
> ------------------------------------------------------------------------------
> Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
> Tap into the largest installed PC base & get more eyes on your game by
> optimizing for Intel(R) Graphics Technology. Get started today with the
> Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
> http://p.sf.net/sfu/intelisp-dev2dev
> _______________________________________________
> Xbmc-addons mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>
Ok, here goes:
I'm not entirely sure that I would call this a new skin. See the
previous discussion about Aeon. Summary: We would prefer to only add
entirely different skins to the repo, no mods. If you consider this to
be a complete skin on its own, and plan to continue maintaining it as
XBMC evolves (separately from Night), please speak up.
Also, please see the other thread and understand that this is not at
all a criticism of your skin, only the way we've decided to ensure
that repo does not fill up with mods.
Now, as I'm sure others will chime in with their thoughts there, I'll
begin the review with the assumption that it is acceptable.
1. And this might be a dealbreaker: It's huge. Once xpr'd and zipped,
it's 100mb even. That's twice the size of most skins, and 25mb bigger
than the largest (Transparency, which is already on the border). 75mb
has been the number in my head, but I suppose we should come up with a
harder limit.
2. remove Thumbs.db.
3. Because of #2, I worry about case sensitivity. Could you please
verify that this is not a problem?
4. version in addon.xml needs a third sub-version. x.y.z please.
5. There's no way that icon.png will be discernible from the couch.
Please see the image guidelines.
6. Please remove any (copy|backup|old) files.
7. See attached xml errors.
FYI, pretty much every skin has had these problems, don't take it personally ;)
Cory
./720p/Viewtype_3dbanner.xml:338: parser error : Opening and ending tag
mismatch: include line 337 and control
</control>
^
./720p/Viewtype_3dbanner.xml:356: parser error : Opening and ending tag
mismatch: control line 293 and include
</include>
^
./720p/Viewtype_3dbanner.xml:357: parser error : expected '>'
</includes>
^
./720p/Viewtype_3dbanner.xml:357: parser error : Premature end of data in tag
includes line 3
</includes>
^
./720p/Font - Copy.xml:19: parser error : Comment not terminated
<!-- <filename>alaska_regular.ttf</filename>
<!
<!-- <filename>alaska_condblack.ttf</filename> -->
^
./720p/IncludesHomeRecentlyAdded.xml:712: parser error : Comment not
terminated
<!--<animation effect="slide" start="500,0" end="0,0"
<!--<animation effect="slide" time="0"
start="0,0" end="0,-20" condition="[L
^
./720p/IncludesHomeRecentlyAdded.xml:944: parser error : Comment not
terminated
<!--<animation effect="slide" start="500,0" end="0,0"
<!--<animation effect="slide" time="0"
start="0,0" end="0,-20" condition="[L
^
./720p/Viewtype_Wall.xml:85: parser error : attributes construct error
<effect
type="zoom" start="100" end="110,100" time="600" delay="2000"tw
^
./720p/Viewtype_Wall.xml:85: parser error : Couldn't find end of Start Tag
effect line 85
<effect
type="zoom" start="100" end="110,100" time="600" delay="2000"tw
^
./720p/Viewtype_Wall.xml:102: parser error : attributes construct error
<effect
type="zoom" start="100" end="120,100" time="600" delay="2000"tw
^
./720p/Viewtype_Wall.xml:102: parser error : Couldn't find end of Start Tag
effect line 102
<effect
type="zoom" start="100" end="120,100" time="600" delay="2000"tw
^
./720p/Viewtype_Wall.xml:121: parser error : attributes construct error
<effect
type="zoom" start="100" end="120,100" time="400" delay="2000"tw
^
./720p/Viewtype_Wall.xml:121: parser error : Couldn't find end of Start Tag
effect line 121
<effect
type="zoom" start="100" end="120,100" time="400" delay="2000"tw
^
./720p/DialogVideoInfo-htpc.xml:26: parser error : Comment not terminated
<!-- <control type="image"><!
<!-- <control type="image"><!-- Floor -->
^
./720p/SettingsSystemInfo.xml:362: parser error : expected '>'
</controls>
^
./720p/SettingsSystemInfo.xml:363: parser error : Opening and ending tag
mismatch: controls line 4 and window
</window>
^
./720p/SettingsSystemInfo.xml:364: parser error : Premature end of data in tag
window line 1
^
./720p/Includes.xml:514: parser error : Comment not terminated
<!-- <control type="group">
<posx>1260</posx>
<!--<control type="label">
^
./720p/script-Rom_Collection_Browser-main.xml:925: parser error : attributes
construct error
<animation effect="slide" start="0,0" end="0,-200"
delay="0"time="400" tween=
^
./720p/script-Rom_Collection_Browser-main.xml:925: parser error : Couldn't
find end of Start Tag animation line 925
<animation effect="slide" start="0,0" end="0,-200"
delay="0"time="400" tween=
^
./720p/script-Rom_Collection_Browser-main.xml:925: parser error : Opening and
ending tag mismatch: control line 923 and animation
tic" easing="out"
condition="!ControlGroup(100).HasFocus">Conditional</animation
^
./720p/script-Rom_Collection_Browser-main.xml:1309: parser error : Opening and
ending tag mismatch: controls line 9 and control
</control>
^
./720p/script-Rom_Collection_Browser-main.xml:1314: parser error : attributes
construct error
<animation effect="slide" start="0,0" end="0,800"
delay="0"time="400" tween="
^
./720p/script-Rom_Collection_Browser-main.xml:1314: parser error : Couldn't
find end of Start Tag animation line 1314
<animation effect="slide" start="0,0" end="0,800"
delay="0"time="400" tween="
^
./720p/script-Rom_Collection_Browser-main.xml:1314: parser error : Opening and
ending tag mismatch: control line 1312 and animation
tic" easing="out"
condition="!ControlGroup(400).HasFocus">Conditional</animation
^
./720p/script-Rom_Collection_Browser-main.xml:1394: parser error : Opening and
ending tag mismatch: window line 1 and control
</control>
^
./720p/script-Rom_Collection_Browser-main.xml:1399: parser error : Extra
content at the end of the document
<control type="label" id="4000">
^
./720p/DialogVideoInfo.xml:26: parser error : Comment not terminated
<!-- <control type="image"><!
<!-- <control type="image"><!-- Floor -->
^
./720p/DialogVideoInfo.xml:543: parser error : attributes construct error
<control type="image"id="7019">
^
./720p/DialogVideoInfo.xml:543: parser error : Couldn't find end of Start Tag
control line 543
<control type="image"id="7019">
^
./720p/DialogVideoInfo.xml:1073: parser error : Opening and ending tag
mismatch: controls line 6 and control
</control>
^
./720p/DialogVideoInfo.xml:1076: parser error : Opening and ending tag
mismatch: window line 1 and controls
</controls>
^
./720p/DialogVideoInfo.xml:1077: parser error : Extra content at the end of
the document
</window>
^
./720p/DialogBottomLine.xml:4: parser error : Premature end of data in tag
window line 2
<include>Video_RSS</include>
^
./720p/custom_DialogBottomLine_11999.xml:25: parser error : Premature end of
data in tag window line 1
</control>
^
./720p/Viewtype_Poster.xml:198: parser error : attributes construct error
ct type="zoom" center="60,238" start="100" end="145,155" time="600"
delay="2000"
^
./720p/Viewtype_Poster.xml:198: parser error : Couldn't find end of Start Tag
effect line 198
ct type="zoom" center="60,238" start="100" end="145,155" time="600"
delay="2000"
^
./720p/Viewtype_Poster.xml:229: parser error : attributes construct error
ct type="zoom" center="60,238" start="100" end="145,155" time="600"
delay="2000"
^
./720p/Viewtype_Poster.xml:229: parser error : Couldn't find end of Start Tag
effect line 229
ct type="zoom" center="60,238" start="100" end="145,155" time="600"
delay="2000"
^
./720p/Viewtype_Poster.xml:244: parser error : attributes construct error
ct type="zoom" center="60,238" start="100" end="145,155" time="600"
delay="2000"
^
./720p/Viewtype_Poster.xml:244: parser error : Couldn't find end of Start Tag
effect line 244
ct type="zoom" center="60,238" start="100" end="145,155" time="600"
delay="2000"
^
./720p/Viewtype_Poster.xml:259: parser error : attributes construct error
ct type="zoom" center="60,238" start="100" end="145,155" time="600"
delay="2000"
^
./720p/Viewtype_Poster.xml:259: parser error : Couldn't find end of Start Tag
effect line 259
ct type="zoom" center="60,238" start="100" end="145,155" time="600"
delay="2000"
^
./720p/Viewtype_Poster.xml:301: parser error : attributes construct error
ct type="zoom" center="60,238" start="100" end="145,155" time="600"
delay="2000"
^
./720p/Viewtype_Poster.xml:301: parser error : Couldn't find end of Start Tag
effect line 301
ct type="zoom" center="60,238" start="100" end="145,155" time="600"
delay="2000"
^
./720p/Viewtype_Poster.xml:318: parser error : attributes construct error
ct type="zoom" center="60,238" start="100" end="145,155" time="600"
delay="2000"
^
./720p/Viewtype_Poster.xml:318: parser error : Couldn't find end of Start Tag
effect line 318
ct type="zoom" center="60,238" start="100" end="145,155" time="600"
delay="2000"
^
./720p/MyVideoNav.xml:10: parser error : EntityRef: expecting ';'
<onfocus>XBMC.RunScript(script.TvTunes,backend=True&loop=False)</
^
./720p/DialogAddonInfo.xml:177: parser error : Comment not terminated
<!-- <control type="label">
<description>header la
<!--<control type="label">
^
------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
