Cory, Thanks for the feedback. While there is still a good bit of Night in this skin, I am developing it to be a skin in and of itself with some shared views from Night. At this point all of the dialogs, fonts, textures, menus, et al are different and the views are being rehashed and added to. If it is still considered too close to Night, I can appreciate that and will wait to submit until I have implemented more changes/diversification from Night.
That aspect aside, to your specific points: 1. Size is down to 60mb now. 2. Thumbs.db gone and added to .gitignore 3. Tested and passed on linux. Looks like case should not be an issue. 4. addon.xml updated to 3 part. 5. Icon updated, though my graphic skills are a bit lacking to say the least. 6. backup/copy files removed 7. Pretty sure all of the xml file errors/issues have been addressed. Thanks for the consideration and feedback. I fully understand if it is not 'unique' enough at this point in time. -stoli- On Sat, Nov 27, 2010 at 11:29 PM, Cory Fields <[email protected]> wrote: > On Fri, Nov 26, 2010 at 1:32 PM, Stoli <[email protected]> wrote: >> - addon -skin.neon >> - version - 0.5 >> - url - git://github.com/stoli/skin.neon.git >> - branch - master >> - revision - 84d804d >> - xbmc version - dharma >> >> My first attempt at this - be gentle. :-) >> >> Thanks. >> stoli >> >> ------------------------------------------------------------------------------ >> Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! >> Tap into the largest installed PC base & get more eyes on your game by >> optimizing for Intel(R) Graphics Technology. Get started today with the >> Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. >> http://p.sf.net/sfu/intelisp-dev2dev >> _______________________________________________ >> Xbmc-addons mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/xbmc-addons >> > > Ok, here goes: > > I'm not entirely sure that I would call this a new skin. See the > previous discussion about Aeon. Summary: We would prefer to only add > entirely different skins to the repo, no mods. If you consider this to > be a complete skin on its own, and plan to continue maintaining it as > XBMC evolves (separately from Night), please speak up. > > Also, please see the other thread and understand that this is not at > all a criticism of your skin, only the way we've decided to ensure > that repo does not fill up with mods. > > Now, as I'm sure others will chime in with their thoughts there, I'll > begin the review with the assumption that it is acceptable. > > 1. And this might be a dealbreaker: It's huge. Once xpr'd and zipped, > it's 100mb even. That's twice the size of most skins, and 25mb bigger > than the largest (Transparency, which is already on the border). 75mb > has been the number in my head, but I suppose we should come up with a > harder limit. > 2. remove Thumbs.db. > 3. Because of #2, I worry about case sensitivity. Could you please > verify that this is not a problem? > 4. version in addon.xml needs a third sub-version. x.y.z please. > 5. There's no way that icon.png will be discernible from the couch. > Please see the image guidelines. > 6. Please remove any (copy|backup|old) files. > 7. See attached xml errors. > > FYI, pretty much every skin has had these problems, don't take it personally > ;) > > Cory > ------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ Xbmc-addons mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbmc-addons
