On Thu, Mar 24, 2011 at 12:13 PM, Stoli <[email protected]> wrote: > - addon - skin.neon > - version - 1.0.1 > - url - git://github.com/stoli/skin.neon.git > - branch - master > - revision - 5e2af54 > - xbmc version - dharma > > Forgot to reply-all > > Cory, > > I've made all of the requested changes except for the deletion of line > 685 in Dialog_AlbumInfo.xml. If I remove this </control>, not only > does the file fail xml validation but the info dialog then fails to > load in the skin. Is there something I am missing? > > Thanks, > John > >> 1. remove: skin.neon/media/LeftRating/Thumbs.db >> 2. remove: MenuItemFOR.pdn >> 3. xml errors: >> skin.neon/720p/DialogAlbumInfo.xml line 14: fix the spacing issue. >> * skin.neon/720p/DialogAlbumInfo.xml line 685. I assume this line >> should be deleted, but please fix it correctly. >> skin.neon/720p/DialogVideoInfo.xml line 512: fix the spacing issue. >> skin.neon/720p/DialogVideoInfo.xml line 732: fix the spacing issue. >> skin.neon/720p/FileBrowser.xml line 33: quotes >> skin.neon/720p/MyVideoNav.xml line 10: & >> skin.neon/720p/Viewtype_List.xml line 606 Standard comments. Please >> use "-->" only, others break strict XML. >> >> Please fix those up. Other than the tiny nits, looks good to me. >> Thanks for the nice skin :) >> >> Cory >> >
It verifies now, perhaps I created an error while fixing some of the others. Thanks for the fixups. Please consider branching for releases. If you intend to maintain this for dharma while adding new/untested features, there's no other way to keep things straight. For ex, commit 1494e20f makes me nervous because it appears as though you waited until after you submitted to the repo to add it. Is that the case? Has it had sufficient testing? Cory ------------------------------------------------------------------------------ Enable your software for Intel(R) Active Management Technology to meet the growing manageability and security demands of your customers. Businesses are taking advantage of Intel(R) vPro (TM) technology - will your software be a part of the solution? Download the Intel(R) Manageability Checker today! http://p.sf.net/sfu/intel-dev2devmar _______________________________________________ Xbmc-addons mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbmc-addons
