On Tue, Mar 22, 2011 at 2:13 PM, Stoli <[email protected]> wrote:
> - addon - skin.neon
> - version - 1.0
> - url - git://github.com/stoli/skin.neon.git
> - branch - master
> - revision  - 39f571a
> - xbmc version - dharma
>
>
> Second try at this - I think it is quite unique at this point to stand
> alone from Night.
>
> Thanks,
> -stoli-
>
> ------------------------------------------------------------------------------
> Enable your software for Intel(R) Active Management Technology to meet the
> growing manageability and security demands of your customers. Businesses
> are taking advantage of Intel(R) vPro (TM) technology - will your software
> be a part of the solution? Download the Intel(R) Manageability Checker
> today! http://p.sf.net/sfu/intel-dev2devmar
> _______________________________________________
> Xbmc-addons mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>

I was hoping to just make some small changes and let you update your
repo to match, but there is one thing below (starred) that you need to
address, so I'll just list them all here. FYI, we enforce strict XML
compliance. There are several small/simple problems, but eliminating
those also helps to point out the big ones.

1. remove: skin.neon/media/LeftRating/Thumbs.db
2. remove: MenuItemFOR.pdn
3. xml errors:
  skin.neon/720p/DialogAlbumInfo.xml line 14: fix the spacing issue.
* skin.neon/720p/DialogAlbumInfo.xml line 685. I assume this line
should be deleted, but please fix it correctly.
  skin.neon/720p/DialogVideoInfo.xml line 512: fix the spacing issue.
  skin.neon/720p/DialogVideoInfo.xml line 732: fix the spacing issue.
  skin.neon/720p/FileBrowser.xml line 33: quotes
  skin.neon/720p/MyVideoNav.xml line 10: &amp;
  skin.neon/720p/Viewtype_List.xml line 606 Standard comments. Please
use "-->" only, others break strict XML.

Please fix those up. Other than the tiny nits, looks good to me.
Thanks for the nice skin :)

Cory

------------------------------------------------------------------------------
Enable your software for Intel(R) Active Management Technology to meet the
growing manageability and security demands of your customers. Businesses
are taking advantage of Intel(R) vPro (TM) technology - will your software 
be a part of the solution? Download the Intel(R) Manageability Checker 
today! http://p.sf.net/sfu/intel-dev2devmar
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to