On Tue, Dec 21, 2010 at 7:18 PM, Cory Fields <[email protected]> wrote: > On Tue, Dec 21, 2010 at 7:15 PM, Wyrm <[email protected]> wrote: >> >> >> On 19 December 2010 23:13, Wyrm <[email protected]> wrote: >>> >>> Initial pull request, be nice! >>> >>> - addon -skin.xtv-saf >>> - version - 1.0.0 >>> - url - >>> http://code.google.com/p/xbmc-repo-wyrm/source/browse/#svn%2Ftrunk%2Fskin.xtv-saf >>> - branch - trunk >>> - revision - 127 >>> - xbmc version - dharma, eden-pre >>> >>> Regards >>> Wyrm >> >> Cory, >> >> Am I to assume that this request has been lost due to the current problem >> with auto update >> >> http://trac.xbmc.org/ticket/10876 >> >> >> Is this likely to be accepted before the 26th (I'm off on holidays for 10 >> days after this date, so will not be available for corrections) or should I >> take back the request? >> >> Wyrm >> >> >> ------------------------------------------------------------------------------ >> Forrester recently released a report on the Return on Investment (ROI) of >> Google Apps. They found a 300% ROI, 38%-56% cost savings, and break-even >> within 7 months. Over 3 million businesses have gone Google with Google >> Apps: >> an online email calendar, and document program that's accessible from your >> browser. Read the Forrester report: http://p.sf.net/sfu/googleapps-sfnew >> _______________________________________________ >> Xbmc-addons mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/xbmc-addons >> >> > > Wyrm > > Thanks for the ping. No particular reason, I just haven't had time to > get to this yet. Sorry about that, It's on my list for tonight. > > Cory >
OK, sorry for the delay. Here's cursory review: 1. And I hate this part, but it's important to help avoid issues down the road: Since this is a mod (or overhaul) of another work, you can't just assign your own license. Do you have permission from CHI3f to assign the CC license? 2. What's with the ThemeInstaller script? Other themes can be bundled with no need for scripts. Ditto for VideoSources.py 3. Most (all?) of the "extras" should be moved into the media/ dir so that they are xpr'd. There was a bug forcing animations out of the media/ dir previously, but this has been resolved. 4. Themes need to be moved into a themes/ dir at root. All files inside must be uncompressed. No zip/xpr/xbt allowed in the repo. See alaska for a working example. 5. Several case-sensitivity issues. Please be sure that the skin works on case-sensitive filesystems. 6. Delete all 4 Thumbs.db. 7. No XML errors. Impressive! Nice skin, it's very snappy! Let's work on those things. When those are out of the way I can nitpick ;) Cory ------------------------------------------------------------------------------ Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Xbmc-addons mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbmc-addons
