On 23 December 2010 11:39, Cory Fields <[email protected]> wrote:
> On Tue, Dec 21, 2010 at 7:18 PM, Cory Fields <[email protected]> wrote:
> > On Tue, Dec 21, 2010 at 7:15 PM, Wyrm <[email protected]>
> wrote:
> >>
> >>
> >> On 19 December 2010 23:13, Wyrm <[email protected]> wrote:
> >>>
> >>> Initial pull request, be nice!
> >>>
> >>> - addon -skin.xtv-saf
> >>> - version - 1.0.0
> >>> - url -
> >>>
> http://code.google.com/p/xbmc-repo-wyrm/source/browse/#svn%2Ftrunk%2Fskin.xtv-saf
> >>> - branch - trunk
> >>> - revision - 127
> >>> - xbmc version - dharma, eden-pre
> >>>
> >>> Regards
> >>> Wyrm
> >>
> >> Cory,
> >>
> >> Am I to assume that this request has been lost due to the current
> problem
> >> with auto update
> >>
> >> http://trac.xbmc.org/ticket/10876
> >>
> >>
> >> Is this likely to be accepted before the 26th (I'm off on holidays for
> 10
> >> days after this date, so will not be available for corrections) or
> should I
> >> take back the request?
> >>
> >> Wyrm
>
Cory, if this comes across as me being annoyed that is not the case (but boy
I am disappointed with the length and number of issues that you have). I
really don't think that this is going to happen before I head off camping,
so it will be probably the middle of January before I can resubmit the skin
for inclusion in the repo. Hopefully if I knock over most of the problems
now, the process will be a lot easier in January when I resubmit the skin.
>
> OK, sorry for the delay. Here's cursory review:
>
> 1. And I hate this part, but it's important to help avoid issues down
> the road: Since this is a mod (or overhaul) of another work, you can't
> just assign your own license. Do you have permission from CHI3f to
> assign the CC license?
>
Two points on this one. Chi3f has made his skin available on Apache v2.0
licence which allows under point 2 of that licence ...Prepare derivative
works of... And the last update to any of his skins occurred on 27th
October 2009, his last post on the forum was on the 21st of October 2009. I
have assumed that the project had been abandoned. I will try to get hold of
Chi3f to see how he feels about me releasing my fork of his code, but if I
change the licence to the Apache licence would that be good enough?
> 2. What's with the ThemeInstaller script? Other themes can be bundled
> with no need for scripts.
Themes require two files (a color.xml file and a theme.xbt file) in two
separate directories. The ThemeInstaller script take the supplied zip file
and places the required files into their correct directories and then
applies the theme if required by the user. The zip file can be local or
pulled from my google code repo. If I did not supply the script the user
would have to go grab the zip, unzip it and then go to a different part of
the skin to apply the theme (and hopefully not mess up any of the previous
steps)
> Ditto for VideoSources.py
>
VideoSources script reads the sources.xml file for names of sources which I
then show in a selection dialog to allow the user to select a source to
default to in file mode (movie, tv or musicvideos). This script is used by
another skin that is already in the repo, so I don't understand why there is
a problem with me using MY script in the skin.
3. Most (all?) of the "extras" should be moved into the media/ dir so
> that they are xpr'd. There was a bug forcing animations out of the
> media/ dir previously, but this has been resolved.
>
Couple of points on this one. All of the media in the extras directory is
of a type that can be added to by the user (studio icons for one) surely it
would be better to keep these type of images out of the default theme as if
these files are xpr'd they can't be added to by the users. Other repo skins
also keep some images out of the default media directory for just this
reason. As to putting these images in extras, seems the best place to keep
them as that is exactly what they are (extras that is). With the talk of
making the weather animation icons something that will be added to the repo
as a addon that all skins can draw on, again it seems silly to place them in
the default themes media directory.
> 4. Themes need to be moved into a themes/ dir at root. All files
> inside must be uncompressed. No zip/xpr/xbt allowed in the repo. See
> alaska for a working example.
>
Now there is no real reason why I can't move the white theme out to my
google code repo, the skin has always shipped with a default theme and a
white theme. Skin used to have the default and white theme in the media
directory (I understand why I can't do that), but I don't understand why
there is a problem with my solution.
> 5. Several case-sensitivity issues. Please be sure that the skin works
> on case-sensitive filesystems.
>
Beta testers have been hard to acquire and even harder to keep. Target
audience does not seem to match with the linux crowd, so I'm not exactly
sure which files are the problem here. Is it the three Rnd... files that
you mean here (code calls everything by it's exact name so I though this
would not be an issue). Only other files with capital letters in the names
are the Default... files which are named in accordance to layed out
standards.
6. Delete all 4 Thumbs.db.
>
Sorry, my bad, fixed with r128 to r131
7. No XML errors. Impressive!
>
Notepad++ and watching this list for what tripped others up. Also part of
the reason why I was floored by your list. Worked very hard not to get
tripped up myself .
Nice skin, it's very snappy! Let's work on those things. When those
> are out of the way I can nitpick ;)
>
Man, what was above then ;-) , but thank you on the "Nice skin" comment.
Let me know what I can do based on my above comments, and I will resubmit
when I get back from camping (Mid January)
Wyrm
>
------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
