On Fri, Jan 14, 2011 at 10:00 AM, Arne Morten Kvarving <[email protected]> wrote: > On Fri, Jan 14, 2011 at 2:58 PM, Wyrm <[email protected]> wrote: >> >> >> On 13 January 2011 08:02, Cory Fields <[email protected]> wrote: >>> >>> On Mon, Jan 10, 2011 at 8:38 AM, Wyrm <[email protected]> wrote: >>> > Cory, >>> > >>> > back from camping trip and have had a chance to fix the issues from the >>> > last >>> > time I submitted the skin, so here goes. >>> > >>> > Initial pull request, part II >>> > >>> > - addon -skin.xtv-saf >>> > - version - 1.0.0 >>> > - url - >>> > >>> > http://code.google.com/p/xbmc-repo-wyrm/source/browse/#svn%2Ftrunk%2Fskin.xtv-saf >>> > - branch - trunk >>> > - revision - 138 >>> > - xbmc version - dharma, eden-pre >>> > >>> > Regards >>> > Wyrm >>> > >>> >>> Sorry for the late response, CES has kept me busy for the last week. >>> >>> We still need to figure out what to do with those scripts. I've talked >>> to the other devs and they agree.. skins should not be packaging >>> scripts. >>> >>> Please explain in detail why you can't just ship your themes with the main >>> skin? >>> >> Cory, >> >> While I still don't understand how you can manage to ship a skin with >> multiple .xbt files in the /media directory that is by the by. Here are my >> reasons why I think using my script is a much better solution to providing >> skin themes. >> >> You mentioned previously that most people download a skin, take a look at it >> and then move on. Surely providing multiple themes in the main download >> when most people will never use then makes little sense. My script >> downloads a theme when required by a user, no redundant themes provided in >> the initial download. >> Ok, if you think providing redundant themes in a skin is fine, just how many >> can you provide before it just gets out of hand? I have four themes >> currently ready and being used for my skin, but I have over ten that where >> previously available for xTV that I will at some point provide for the skin >> after converting to my package format. >> Not a problem for my skin, but each theme takes up space. At about 1-2 Meg >> for each theme, what happens when we start knocking on your 75M skin size >> limit? My themes are hosted on a googlecode page, so no issues for you with >> space to store themes or the bandwidth to download them. >> Ok, I've just discovered a small problem with my theme. Your way, I have to >> submit a pull request for an update, wait for you to accept the pull and >> upload to your servers. My way, make change to theme package, upload to >> googlecode page and then post a message to the forum telling anyone using >> that particular theme to re-download the theme.. Which way is better? >> As mentioned before themes generally require two files (a colour.xml file >> and a colour.xbt file). If someone else wants to provide themes for my skin >> they can zip up the two files and post a link to the file. User then only >> has to download the file to my extras/themes directory and press Install >> theme button to have my script unpack the files to their correct >> directories. > > rewrite the script to be general purpose, submit a pull request for > it, then depend on it in the skin. > > ------------------------------------------------------------------------------ > Protect Your Site and Customers from Malware Attacks > Learn about various malware tactics and how to avoid them. Understand > malware threats, the impact they can have on your business, and how you > can protect your company and customers by using code signing. > http://p.sf.net/sfu/oracle-sfdevnl > _______________________________________________ > Xbmc-addons mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/xbmc-addons >
Yep, what he said. It may be easier for your skin, but packaging scripts makes our life harder. Also, it may be high SAF, but then what happens when your S switches to another skin and looks for "System->Themes" ? We have plans for breaking skins into components in the future (fonts, icons, themes, etc). We ask that you please abide by our guidelines for now. Thanks, Cory ------------------------------------------------------------------------------ Protect Your Site and Customers from Malware Attacks Learn about various malware tactics and how to avoid them. Understand malware threats, the impact they can have on your business, and how you can protect your company and customers by using code signing. http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Xbmc-addons mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbmc-addons
