>>> On 22.11.17 at 20:20, <george.dun...@citrix.com> wrote: > +## Debugging, analysis, and crash post-mortem > + > +### Host serial console > + > + Status, NS16550: Supported > + Status, EHCI: Supported
Inconsistent indentation. > + Status, Cadence UART (ARM): Supported > + Status, PL011 UART (ARM): Supported > + Status, Exynos 4210 UART (ARM): Supported > + Status, OMAP UART (ARM): Supported > + Status, SCI(F) UART: Supported > + > +XXX Should NS16550 and EHCI be limited to x86? Unlike the ARM > +entries, they don't depend on x86 being configured ns16550 ought to be usable everywhere. EHCI is x86-only anyway (presumably first of all because it takes PCI as a prereq) - there's a "select" needed, which only x86 has. In the end I view the ARM way of expressing things wrong there: I think all "HAS_*" items would better require "select"s (unless, like for ns16550, they're there sort of for documentation / consistency purpose only). With this XXX dropped (and with or without adding (x86) to EHCI) Acked-by: Jan Beulich <jbeul...@suse.com> Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
