On 21/8/06 10:20 am, "Tristan Gingold" <[EMAIL PROTECTED]> wrote:

>> Fine in principle. Specific comments:
>>  * powerpc should be cleaned up at the same time to use the common
>> infrastructure. I don't want duplicated code hanging around in arch/powerpc
> I have attached a blindly-made patch again powerpc files.
> If ppc people could check this, I'd be happy.
> 
>>  * The code you add to common/ should obey the coding style of other files
>> in that directory
>>  * Arguably we should have an asm-generic for the xencomm guest-access
>> macros. That's a Linux-ism which I think fits well in this particular case.
> Taken into account in this updated patch.

Looks better. I assume you'll resend with signed-off-by when you want these
applied.

 -- Keir



_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@lists.xensource.com
http://lists.xensource.com/xen-ppc-devel

Reply via email to