On Wed, 23 Aug 2006 10:15:41 +0200, Tristan Gingold wrote:
> [-- text/plain, encoding quoted-printable, charset: iso-8859-1, 34 lines --]
> Le Lundi 21 Août 2006 11:41, Keir Fraser a écrit :
>> On 21/8/06 10:20 am, "Tristan Gingold" <[EMAIL PROTECTED]> wrote:
>> >> Fine in principle. Specific comments:
>> >> * powerpc should be cleaned up at the same time to use the common
>> >> infrastructure. I don't want duplicated code hanging around in
>> >> arch/powerpc
>> > I have attached a blindly-made patch again powerpc files.
>> > If ppc people could check this, I'd be happy.
>> >> * The code you add to common/ should obey the coding style of other
>> >> files in that directory
>> >> * Arguably we should have an asm-generic for the xencomm guest-access
>> >> macros. That's a Linux-ism which I think fits well in this particular
>> >> case.
>> > Taken into account in this updated patch.
>> Looks better. I assume you'll resend with signed-off-by when you want these
> here are the signed-off-by patches for xen.
> I took the liberty to add Hollis Blanchard in signed-off-by of the first
> because he is the primary author of these files.
I suspect that CC is better than Signed-Off in this case.
Xen-ppc-devel mailing list