Agree. But that will revert totally 5/29/2010 patch.
Thanks, Frank > -----Original Message----- > From: Julien Cristau [mailto:[email protected]] > Sent: 2010?9?30? 14:28 > To: Huang, FrankR > Cc: Geode Mailing List; [email protected]; [email protected] > Subject: Re: xf86-video-geode: Changes to 'master' > > On Thu, Sep 30, 2010 at 13:56:27 +0800, Huang, FrankR wrote: > > > I definitely know MODE_OK will be returned in this function now for > > every condition. But you should know my patch is based on the patch > > Otavio committed on 5/29/2010. If there is some condition we need give > > MODE_XXX, we can add code. But the last return value of this function > > must be MODE_OK. That is my point. > > Then write it as > > lx_output_mode_valid() > { > return MODE_OK; > } > > which will be equivalent to the current code, but not quite as > convoluted. > > Cheers, > Julien _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
