On Thu, 2010-09-30 at 15:49 +0800, Huang, FrankR wrote: > So we can keep the current git code with no change.
You can, but the code is still _wrong_. Wrong wrong wrong. Your hardware has real constraints; you have finite memory bandwidth, and finite DAC speed, and finite CRTC addressibility. If I try this modeline on your hardware: atropine:~% gtf 1920 1440 120 # 1920x1440 @ 120.00 Hz (GTF) hsync: 185.16 kHz; pclk: 497.71 MHz Modeline "1920x1440_120.00" 497.71 1920 2088 2304 2688 1440 1441 1444 1543 -HSync +Vsync it will not work. The code as you've now changed it will happily accept this mode. And your commit message is wrong too. The other drivers you mention check for failure conditions before returning MODE_OK. You're checking for _success_ conditions and then returning MODE_OK all the time. Textually these look very similar; semantically they're completely different. Think. Please. - ajax
signature.asc
Description: This is a digitally signed message part
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
